diff options
author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2023-12-07 10:21:01 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-07 10:21:01 +0100 |
commit | 31640652c7b5e1a430ab7dfb894347aff96cddd7 (patch) | |
tree | 8b0b8c9070b711cad1e5f6bcb33de60c191cbcb6 /var/spack/repos/builtin/packages/exago | |
parent | 0ff0e8944ec97b3dd3e47ea2a6224ad3095448ed (diff) | |
download | spack-31640652c7b5e1a430ab7dfb894347aff96cddd7.tar.gz spack-31640652c7b5e1a430ab7dfb894347aff96cddd7.tar.bz2 spack-31640652c7b5e1a430ab7dfb894347aff96cddd7.tar.xz spack-31640652c7b5e1a430ab7dfb894347aff96cddd7.zip |
audit: forbid nested dependencies in depends_on declarations (#41428)
Forbid nested dependencies in depends_on declarations, by running an audit in CI.
Fix the packages not passing the new audit:
- amd-aocl
- exago
- palace
- shapemapper
- xsdk-examples
ginkgo: add a commit sha to v1.5.0.glu_experimental
Diffstat (limited to 'var/spack/repos/builtin/packages/exago')
-rw-r--r-- | var/spack/repos/builtin/packages/exago/package.py | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/var/spack/repos/builtin/packages/exago/package.py b/var/spack/repos/builtin/packages/exago/package.py index 44ede70fa6..415a27e077 100644 --- a/var/spack/repos/builtin/packages/exago/package.py +++ b/var/spack/repos/builtin/packages/exago/package.py @@ -124,14 +124,15 @@ class Exago(CMakePackage, CudaPackage, ROCmPackage): when="+{0} build_type=RelWithDebInfo".format(pkg[1]), ) - depends_on( - "{0} build_type=Release".format("hiop+ginkgo ^ginkgo"), - when="+{0} build_type=Release".format("hiop ^hiop+ginkgo"), - ) - depends_on( - "{0} build_type=Debug".format("hiop+ginkgo ^ginkgo"), - when="+{0} build_type=RelWithDebInfo".format("hiop ^hiop+ginkgo"), - ) + with when("+hiop"): + depends_on("hiop") + with when("build_type=Release"): + depends_on("hiop build_type=Release") + depends_on("ginkgo build_type=Release", when="^hiop+ginkgo") + with when("build_type=Debug"): + depends_on("hiop build_type=RelWithDebInfo") + depends_on("ginkgo build_type=Debug", when="^hiop+ginkgo") + # depends_on("hpctoolkit", when="with_profiling=hpctoolkit") # depends_on("tau", when="with_profiling=tau") # ^ need to depend when both hpctoolkit and tau |