diff options
author | Adam J. Stewart <ajstewart426@gmail.com> | 2022-03-23 02:50:00 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-23 08:50:00 +0100 |
commit | 5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34 (patch) | |
tree | b8ef0badda8ff94202d35c5bebd80e3163d8cb70 /var/spack/repos/builtin/packages/icu4c/package.py | |
parent | 8f89932aad0bdba3e4ffad57e9973118f73a0bb6 (diff) | |
download | spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.gz spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.bz2 spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.xz spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.zip |
Use stable URLs and `?full_index=1` for all github patches (#29239)
The number of commit characters in patch files fetched from GitHub can change,
so we should use `full_index=1` to enforce full commit hashes (and a stable
patch `sha256`).
Similarly, URLs for branches like `master` don't give us stable patch files,
because branches are moving targets. Use specific tags or commits for those.
- [x] update all github patch URLs to use `full_index=1`
- [x] don't use `master` or other branches for patches
- [x] add an audit check and a test for `?full_index=1`
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
Diffstat (limited to 'var/spack/repos/builtin/packages/icu4c/package.py')
-rw-r--r-- | var/spack/repos/builtin/packages/icu4c/package.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/var/spack/repos/builtin/packages/icu4c/package.py b/var/spack/repos/builtin/packages/icu4c/package.py index 25391144f3..abd09a6229 100644 --- a/var/spack/repos/builtin/packages/icu4c/package.py +++ b/var/spack/repos/builtin/packages/icu4c/package.py @@ -38,8 +38,8 @@ class Icu4c(AutotoolsPackage): conflicts('%gcc@:4', when='@67.1:', msg="Older GCC compilers have immature C++11 support") - patch('https://github.com/unicode-org/icu/commit/ddfc30860354cbcb78c2c0bcf800be5ab44a9e4f.patch', - sha256='dfc501d78ddfabafe09dc1a7aa70f96b799164b18f6a57d616a9d48aaf989333', + patch('https://github.com/unicode-org/icu/commit/ddfc30860354cbcb78c2c0bcf800be5ab44a9e4f.patch?full_index=1', + sha256='6be0b8068b0f5047dad7f4f6f655529304f1abbc551c93223c6f41dafc1e8acc', level=2, when='@58.0:59') configure_directory = 'source' |