diff options
| author | Todd Gamblin <tgamblin@llnl.gov> | 2023-03-05 07:58:05 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-05 07:58:05 -0800 |
| commit | 42a02411b478f1fa3f6ab9c5e30b92b4df64d085 (patch) | |
| tree | 8641bbc4405aab2ed74c51c88833363f4c9d29b4 /var/spack/repos/builtin/packages/scons/package.py | |
| parent | 456153640354b3ca64dfad53e86d3a3c7726c684 (diff) | |
| download | spack-42a02411b478f1fa3f6ab9c5e30b92b4df64d085.tar.gz spack-42a02411b478f1fa3f6ab9c5e30b92b4df64d085.tar.bz2 spack-42a02411b478f1fa3f6ab9c5e30b92b4df64d085.tar.xz spack-42a02411b478f1fa3f6ab9c5e30b92b4df64d085.zip | |
windows: use `sys.platform == "win32"` instead of `is_windows` (#35640)
`mypy` only understands `sys.platform == "win32"`, not indirect assignments of that
value to things like `is_windows`. If we don't use the accepted platform checks, `mypy`
registers many Windows-only symbols as not present on Linux, when it should skip the
checks for platform-specific code.
Diffstat (limited to 'var/spack/repos/builtin/packages/scons/package.py')
| -rw-r--r-- | var/spack/repos/builtin/packages/scons/package.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/var/spack/repos/builtin/packages/scons/package.py b/var/spack/repos/builtin/packages/scons/package.py index bb5bfea725..095fa5e275 100644 --- a/var/spack/repos/builtin/packages/scons/package.py +++ b/var/spack/repos/builtin/packages/scons/package.py @@ -6,8 +6,6 @@ import sys from spack.package import * -is_windows = sys.platform == "win32" - class Scons(PythonPackage): """SCons is a software construction tool""" @@ -55,7 +53,7 @@ class Scons(PythonPackage): env.prepend_path("PYTHONPATH", self.prefix.lib.scons) def setup_dependent_package(self, module, dspec): - if is_windows: + if sys.platform == "win32": module.scons = Executable(self.spec.prefix.Scripts.scons) else: module.scons = Executable(self.spec.prefix.bin.scons) |