make version(...) kwargs explicit (#36998)

- [x] Replace `version(ver, checksum=None, **kwargs)` signature with
      `version(ver, checksum=None, *, sha256=..., ...)` explicitly listing all arguments.
- [x] Fix various issues in packages:
  - `tags` instead of `tag`
  - `default` instead of `preferred`
  - `sha26` instead of `sha256`
  - etc

Also, use `sha256=...` consistently.

Note: setting `sha256` currently doesn't validate the checksum length, so you could do
`sha256="a"*32` and it would get checked as `md5`... but that's something for another PR.

4 files changed, 31 insertions, 31 deletions

diff --git a/var/spack/repos/tutorial/packages/armadillo/package.py b/var/spack/repos/tutorial/packages/armadillo/package.py
index 77f4c68c62..a4885bcfdc 100644
--- a/var/spack/repos/tutorial/packages/armadillo/package.py
+++ b/var/spack/repos/tutorial/packages/armadillo/package.py
@@ -15,12 +15,12 @@ class Armadillo(CMakePackage):
     homepage = "http://arma.sourceforge.net/"
     url = "http://sourceforge.net/projects/arma/files/armadillo-7.200.1.tar.xz"
 
-    version("8.100.1", "d9762d6f097e0451d0cfadfbda295e7c")
-    version("7.950.1", "c06eb38b12cae49cab0ce05f96147147")
-    version("7.900.1", "5ef71763bd429a3d481499878351f3be")
-    version("7.500.0", "7d316fdf3c3c7ea92b64704180ae315d")
-    version("7.200.2", "b21585372d67a8876117fd515d8cf0a2")
-    version("7.200.1", "ed86d6df0058979e107502e1fe3e469e")
+    version("8.100.1", md5="d9762d6f097e0451d0cfadfbda295e7c")
+    version("7.950.1", md5="c06eb38b12cae49cab0ce05f96147147")
+    version("7.900.1", md5="5ef71763bd429a3d481499878351f3be")
+    version("7.500.0", md5="7d316fdf3c3c7ea92b64704180ae315d")
+    version("7.200.2", md5="b21585372d67a8876117fd515d8cf0a2")
+    version("7.200.1", md5="ed86d6df0058979e107502e1fe3e469e")
 
     variant("hdf5", default=False, description="Include HDF5 support")
 
diff --git a/var/spack/repos/tutorial/packages/elpa/package.py b/var/spack/repos/tutorial/packages/elpa/package.py
index 5906a3557b..fcfc6b0251 100644
--- a/var/spack/repos/tutorial/packages/elpa/package.py
+++ b/var/spack/repos/tutorial/packages/elpa/package.py
@@ -12,14 +12,14 @@ class Elpa(AutotoolsPackage):
     homepage = "http://elpa.mpcdf.mpg.de/"
     url = "http://elpa.mpcdf.mpg.de/elpa-2015.11.001.tar.gz"
 
-    version("2018.05.001.rc1", "ccd77bd8036988ee624f43c04992bcdd")
-    version("2017.11.001", "4a437be40cc966efb07aaab84c20cd6e", preferred=True)
-    version("2017.05.003", "7c8e5e58cafab212badaf4216695700f")
-    version("2017.05.002", "d0abc1ac1f493f93bf5e30ec8ab155dc")
-    version("2016.11.001.pre", "5656fd066cf0dcd071dbcaf20a639b37")
-    version("2016.05.004", "c0dd3a53055536fc3a2a221e78d8b376")
-    version("2016.05.003", "88a9f3f3bfb63e16509dd1be089dcf2c")
-    version("2015.11.001", "de0f35b7ee7c971fd0dca35c900b87e6")
+    version("2018.05.001.rc1", md5="ccd77bd8036988ee624f43c04992bcdd")
+    version("2017.11.001", md5="4a437be40cc966efb07aaab84c20cd6e", preferred=True)
+    version("2017.05.003", md5="7c8e5e58cafab212badaf4216695700f")
+    version("2017.05.002", md5="d0abc1ac1f493f93bf5e30ec8ab155dc")
+    version("2016.11.001.pre", md5="5656fd066cf0dcd071dbcaf20a639b37")
+    version("2016.05.004", md5="c0dd3a53055536fc3a2a221e78d8b376")
+    version("2016.05.003", md5="88a9f3f3bfb63e16509dd1be089dcf2c")
+    version("2015.11.001", md5="de0f35b7ee7c971fd0dca35c900b87e6")
 
     variant("openmp", default=False, description="Activates OpenMP support")
     variant("optflags", default=True, description="Build with optimization flags")
diff --git a/var/spack/repos/tutorial/packages/mpich/package.py b/var/spack/repos/tutorial/packages/mpich/package.py
index 657a9671aa..9d3592fdfd 100644
--- a/var/spack/repos/tutorial/packages/mpich/package.py
+++ b/var/spack/repos/tutorial/packages/mpich/package.py
@@ -19,14 +19,14 @@ class Mpich(AutotoolsPackage):
     list_depth = 1
 
     version("develop", submodules=True)
-    version("3.2.1", "e175452f4d61646a52c73031683fc375")
-    version("3.2", "f414cfa77099cd1fa1a5ae4e22db508a")
-    version("3.1.4", "2ab544607986486562e076b83937bba2")
-    version("3.1.3", "93cb17f91ac758cbf9174ecb03563778")
-    version("3.1.2", "7fbf4b81dcb74b07ae85939d1ceee7f1")
-    version("3.1.1", "40dc408b1e03cc36d80209baaa2d32b7")
-    version("3.1", "5643dd176499bfb7d25079aaff25f2ec")
-    version("3.0.4", "9c5d5d4fe1e17dd12153f40bc5b6dbc0")
+    version("3.2.1", md5="e175452f4d61646a52c73031683fc375")
+    version("3.2", md5="f414cfa77099cd1fa1a5ae4e22db508a")
+    version("3.1.4", md5="2ab544607986486562e076b83937bba2")
+    version("3.1.3", md5="93cb17f91ac758cbf9174ecb03563778")
+    version("3.1.2", md5="7fbf4b81dcb74b07ae85939d1ceee7f1")
+    version("3.1.1", md5="40dc408b1e03cc36d80209baaa2d32b7")
+    version("3.1", md5="5643dd176499bfb7d25079aaff25f2ec")
+    version("3.0.4", md5="9c5d5d4fe1e17dd12153f40bc5b6dbc0")
 
     variant("hydra", default=True, description="Build the hydra process manager")
     variant("pmi", default=True, description="Build with PMI support")
diff --git a/var/spack/repos/tutorial/packages/netlib-lapack/package.py b/var/spack/repos/tutorial/packages/netlib-lapack/package.py
index ff98d722e3..bfc134b5c7 100644
--- a/var/spack/repos/tutorial/packages/netlib-lapack/package.py
+++ b/var/spack/repos/tutorial/packages/netlib-lapack/package.py
@@ -23,15 +23,15 @@ class NetlibLapack(CMakePackage):
         "96591affdbf58c450d45c1daa540dbd2",
         url="http://www.netlib.org/lapack/lapack-3.8.0.tar.gz",
     )
-    version("3.7.1", "dcdeeed73de152c4643ccc5b1aeb453c")
-    version("3.7.0", "697bb8d67c7d336a0f339cc9dd0fa72f")
-    version("3.6.1", "421b2cb72e15f237e144428f9c460ee0")
-    version("3.6.0", "f2f6c67134e851fe189bb3ca1fbb5101")
-    version("3.5.0", "b1d3e3e425b2e44a06760ff173104bdf")
-    version("3.4.2", "61bf1a8a4469d4bdb7604f5897179478")
-    version("3.4.1", "44c3869c38c8335c2b9c2a8bb276eb55")
-    version("3.4.0", "02d5706ec03ba885fc246e5fa10d8c70")
-    version("3.3.1", "d0d533ec9a5b74933c2a1e84eedc58b4")
+    version("3.7.1", md5="dcdeeed73de152c4643ccc5b1aeb453c")
+    version("3.7.0", md5="697bb8d67c7d336a0f339cc9dd0fa72f")
+    version("3.6.1", md5="421b2cb72e15f237e144428f9c460ee0")
+    version("3.6.0", md5="f2f6c67134e851fe189bb3ca1fbb5101")
+    version("3.5.0", md5="b1d3e3e425b2e44a06760ff173104bdf")
+    version("3.4.2", md5="61bf1a8a4469d4bdb7604f5897179478")
+    version("3.4.1", md5="44c3869c38c8335c2b9c2a8bb276eb55")
+    version("3.4.0", md5="02d5706ec03ba885fc246e5fa10d8c70")
+    version("3.3.1", md5="d0d533ec9a5b74933c2a1e84eedc58b4")
 
     variant("shared", default=True, description="Build shared library version")
     variant("external-blas", default=False, description="Build lapack with an external blas")