summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorMassimiliano Culpo <massimiliano.culpo@gmail.com>2020-12-01 10:11:40 +0100
committerTamara Dahlgren <dahlgren1@llnl.gov>2021-02-17 17:07:18 -0800
commit1e1a6f4e3068831a7d2ffd250db0029f4603444d (patch)
treeb2e7177f99bde476957d1f9035dba06aaadfb2f5 /var
parent22d7937c50fa56e8db3819ae1039c0bb26383bd1 (diff)
downloadspack-1e1a6f4e3068831a7d2ffd250db0029f4603444d.tar.gz
spack-1e1a6f4e3068831a7d2ffd250db0029f4603444d.tar.bz2
spack-1e1a6f4e3068831a7d2ffd250db0029f4603444d.tar.xz
spack-1e1a6f4e3068831a7d2ffd250db0029f4603444d.zip
concretizer: remove ad-hoc rule for external packages (#20193)
fixes #20040 Matching compilers among nodes has been prioritized in #20020. Selection of default variants has been tuned in #20182. With this setup there is no need to have an ad-hoc rule for external packages. On the contrary it should be removed to prefer having default variant values over more external nodes in the DAG.
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin.mock/packages/vdefault-or-external-root/package.py15
-rw-r--r--var/spack/repos/builtin.mock/packages/vdefault-or-external/package.py17
2 files changed, 32 insertions, 0 deletions
diff --git a/var/spack/repos/builtin.mock/packages/vdefault-or-external-root/package.py b/var/spack/repos/builtin.mock/packages/vdefault-or-external-root/package.py
new file mode 100644
index 0000000000..49011fc458
--- /dev/null
+++ b/var/spack/repos/builtin.mock/packages/vdefault-or-external-root/package.py
@@ -0,0 +1,15 @@
+# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+class VdefaultOrExternalRoot(Package):
+ """Test that we don't prefer adding an external to using
+ a default variant value.
+ """
+
+ homepage = 'https://www.example.org'
+ url = 'https://example.org/files/v3.4/cmake-3.4.3.tar.gz'
+
+ version('1.0', '4cb3ff35b2472aae70f542116d616e63')
+
+ depends_on('vdefault-or-external')
diff --git a/var/spack/repos/builtin.mock/packages/vdefault-or-external/package.py b/var/spack/repos/builtin.mock/packages/vdefault-or-external/package.py
new file mode 100644
index 0000000000..80c674917e
--- /dev/null
+++ b/var/spack/repos/builtin.mock/packages/vdefault-or-external/package.py
@@ -0,0 +1,17 @@
+# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+class VdefaultOrExternal(Package):
+ """Test that we don't prefer adding an external to using
+ a default variant value.
+ """
+
+ homepage = 'https://www.example.org'
+ url = 'https://example.org/files/v3.4/cmake-3.4.3.tar.gz'
+
+ version('1.0', '4cb3ff35b2472aae70f542116d616e63')
+
+ variant('external', default=False, description='nope')
+
+ depends_on('externaltool', when='+external')