zziplib: support multiple build systems (#37058)

This PR rewrites the zziplib recipe to use Spack's multiple build system
support.

1 files changed, 16 insertions, 38 deletions

diff --git a/var/spack/repos/builtin/packages/zziplib/package.py b/var/spack/repos/builtin/packages/zziplib/package.py
index 565466ebbd..9559e2b132 100644
--- a/var/spack/repos/builtin/packages/zziplib/package.py
+++ b/var/spack/repos/builtin/packages/zziplib/package.py
@@ -3,10 +3,12 @@
 #
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
 
+import spack.build_systems.autotools
+import spack.build_systems.cmake
 from spack.package import *
 
 
-class Zziplib(AutotoolsPackage):
+class Zziplib(AutotoolsPackage, CMakePackage):
     """The zziplib provides read access to zipped files in a zip-archive, using
     compression based solely on free algorithms provided by zlib.  It also
     provides a functionality to overlay the archive filesystem with the
@@ -15,51 +17,27 @@ class Zziplib(AutotoolsPackage):
     homepage = "https://github.com/gdraheim/zziplib"
     url = "https://github.com/gdraheim/zziplib/archive/v0.13.69.tar.gz"
 
-    # Switch to CMake from 0.13.70, first working release is 0.13.71
     version("0.13.72", sha256="93ef44bf1f1ea24fc66080426a469df82fa631d13ca3b2e4abaeab89538518dc")
     version("0.13.69", sha256="846246d7cdeee405d8d21e2922c6e97f55f24ecbe3b6dcf5778073a88f120544")
 
     patch("python2to3.patch", when="@:0.13.69")
 
-    build_directory = "spack-build"
+    # Switch to CMake from 0.13.70, first working release is 0.13.71
+    build_system(
+        conditional("cmake", when="@0.13.72:"),
+        conditional("autotools", when="@:0.13.69"),
+        default="cmake",
+    )
 
-    depends_on("python@3.5:", type="build", when="@0.13.71:")
-    depends_on("cmake", type="build", when="@0.13.71:")
+    depends_on("python@3.5:", type="build", when="@0.13.72:")
     depends_on("python", type="build")
     depends_on("zlib")
     # see zzip/CMakeLists.txt
-    depends_on("coreutils", type="build", when="@0.13.71:")
-    depends_on("pkgconfig", type="build", when="@0.13.71:")
-    depends_on("zip", type="build", when="@0.13.71:")
-    depends_on("unzip", type="build", when="@0.13.71:")
-
-    @when("@0.13.71:")
-    def autoreconf(self, spec, prefix):
-        touch("configure")
+    depends_on("coreutils", type="build", when="@0.13.72:")
+    depends_on("pkgconfig", type="build", when="@0.13.72:")
+    depends_on("zip", type="build", when="@0.13.72:")
+    depends_on("unzip", type="build", when="@0.13.72:")
 
-    @when("@0.13.71:")
-    def _cmake_args(self):
-        spec = self.spec
-        args = []
-        zlib = spec["zlib"]
-        # Do not use self.define('VAR', path) unless a CMakePackage
-        args.extend(
-            [
-                "-DZLIB_LIBRARY:FILEPATH={0}".format(zlib.libs[0]),
-                "-DZLIB_INCLUDE_DIR:FILEPATH={0}".format(zlib.headers.directories[0]),
-            ]
-        )
-        args.append("-DPYTHON_EXECUTABLE:FILEPATH={0}".format(spec["python"].command.path))
-        args.append("-DCMAKE_INSTALL_PREFIX:PATH={0}".format(spec.prefix))
 
-        return args
-
-    def configure_args(self):
-        args = ["--with-zlib={0}".format(self.spec["zlib"].prefix)]
-        return args
-
-    @when("@0.13.71:")
-    def configure(self, spec, prefix):
-        with working_dir("spack-build", create=True):
-            cmake_args = self._cmake_args()
-            cmake("..", *cmake_args)
+class AutotoolsBuilder(spack.build_systems.autotools.AutotoolsBuilder):
+    build_directory = "spack-build"