Add a new version (7.2) of draco. (#11852)

This change also
+ Makes the `build_type` user settable and
+ Adds support for running tests.
+ Provide depends_on('cmake') for versions prior to 7.0.

1 files changed, 40 insertions, 11 deletions

diff --git a/var/spack/repos/builtin/packages/draco/package.py b/var/spack/repos/builtin/packages/draco/package.py
index bf8ebfbd6b..0834ada36e 100644
--- a/var/spack/repos/builtin/packages/draco/package.py
+++ b/var/spack/repos/builtin/packages/draco/package.py
@@ -17,6 +17,7 @@ class Draco(CMakePackage):
     git = "https://github.com/lanl/Draco.git"
 
     version('develop', branch='develop')
+    version('7.2.0',  sha256='ac4eac03703d4b7344fa2390a54140533c5e1f6ea0d59ef1f1d525c434ebe639')
     version('7_1_0',  sha256='eca6bb86eb930837fb5e09b76c85c200b2c1522267cc66f81f2ec11a8262b5c9')
     version('6_25_0', sha256='e27eba44f397e7d111ff9a45b518b186940f75facfc6f318d76bd0e72f987440')
     version('6_23_0', sha256='edf20308746c06647087cb4e6ae7656fd057a89091a22bcba8f17a52e28b7849')
@@ -25,20 +26,48 @@ class Draco(CMakePackage):
     version('6_20_1', sha256='b1c51000c9557e0818014713fce70d681869c50ed9c4548dcfb2e9219c354ebe')
     version('6_20_0', sha256='a6e3142c1c90b09c4ff8057bfee974369b815122b01d1f7b57888dcb9b1128f6')
 
-    variant('lapack',   default=False, description='Enable LAPACK Wrapper')
+    variant('build_type', default='Release', description='CMake build type',
+            values=('Debug', 'Release', 'RelWithDebInfo', 'MinSizeRel'))
     variant('eospac',   default=False, description='Enable EOSPAC Support')
+    variant('lapack',   default=False, description='Enable LAPACK Wrapper')
     variant('parmetis', default=False, description='Enable Parmetis Support')
     variant('qt',       default=False, description='Enable Qt Support')
     variant('superlu_dist', default=False, description='Enable SuperLU-DIST Support')
 
-    depends_on('mpi@3:',    type=('build', 'run'))
+    depends_on('gsl',       type=('build', 'link'))
+    depends_on('mpi@3:',    type=('build', 'link', 'run'))
+    depends_on('numdiff',   type='build')
+    depends_on('python@2.7:', type=('build', 'run'))
     depends_on('random123', type='build')
-    depends_on('gsl',       type='build')
-    depends_on('python',    type=('build', 'run'))
-    depends_on('numdiff',   type='run')
-
-    depends_on('lapack',   when='+lapack', type='build')
-    depends_on('eospac',   when='+eospac', type='build')
-    depends_on('parmetis', when='+parmetis', type='build')
-    depends_on('qt', when='+qt', type=('build', 'run'))
-    depends_on('superlu-dist@:5.99', when='+superlu_dist', type='build')
+
+    depends_on('cmake@3.9:',  when='@:6.99',       type='build')
+    depends_on('cmake@3.11:', when='@7.0.0:7.1.9', type='build')
+    depends_on('cmake@3.14:', when='@7.2:',        type='build')
+    depends_on('eospac@6.3:', when='+eospac',      type=('build', 'link'))
+    depends_on('lapack',      when='+lapack',      type=('build', 'link'))
+    depends_on('metis',       when='+parmetis',    type=('build', 'link'))
+    depends_on('parmetis',    when='+parmetis',    type=('build', 'link'))
+    depends_on('qt',          when='+qt',
+               type=('build', 'link', 'run'))
+    depends_on('superlu-dist@:5.99', when='+superlu-dist',
+               type=('build', 'link'))
+
+    def url_for_version(self, version):
+        url = "https://github.com/lanl/Draco/archive/draco-{0}.zip"
+        return url.format(version.underscored)
+
+    def cmake_args(self):
+        options = []
+        options.extend([
+            '-Wno-dev',
+            '-DBUILD_TESTING={0}'.format('ON' if self.run_tests else 'OFF')
+        ])
+        return options
+
+    @run_after('build')
+    @on_package_attributes(run_tests=True)
+    def check(self):
+        """Run ctest after building project."""
+
+        with working_dir(self.build_directory):
+            ctest()