diff options
| author | Todd Gamblin <tgamblin@llnl.gov> | 2017-10-14 00:30:17 -0700 |
|---|---|---|
| committer | Todd Gamblin <tgamblin@llnl.gov> | 2017-10-17 01:26:31 -0700 |
| commit | c14f2dc7b41426e892ca1d558ba026004531caa1 (patch) | |
| tree | dcc91c3848300a110a52ebcd9a59741d49455b5e /var | |
| parent | 890c5ad329fd6668074c94bf448f2209c0eff4a6 (diff) | |
| download | spack-c14f2dc7b41426e892ca1d558ba026004531caa1.tar.gz spack-c14f2dc7b41426e892ca1d558ba026004531caa1.tar.bz2 spack-c14f2dc7b41426e892ca1d558ba026004531caa1.tar.xz spack-c14f2dc7b41426e892ca1d558ba026004531caa1.zip | |
Spack core and tests no longer use `os.chdir()`
- Spack's core package interface was previously overly stateful, in that
calling methods like `do_stage()` could change your working directory.
- This removes Stage's `chdir` and `chdir_to_source` methods and replaces
their usages with `with working_dir(stage.path)` and `with
working_dir(stage.source_path)`, respectively. These ensure the
original working directory is preserved.
- This not only makes the API more usable, it makes the tests more
deterministic, as previously a test could leave the current working
directory in a bad state and cause subsequent tests to fail
mysteriously.
Diffstat (limited to 'var')
0 files changed, 0 insertions, 0 deletions