diff options
| author | Seth R. Johnson <johnsonsr@ornl.gov> | 2020-10-28 21:47:16 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-28 20:47:16 -0500 |
| commit | ef9c80de233cb5491c11b39c7c261fbfb9d48e92 (patch) | |
| tree | 9604a3d089b2ed02c40e61f3612a3ae353106436 /var | |
| parent | f7269ffd0a4ecd875cfef6ee959babbc181ff98f (diff) | |
| download | spack-ef9c80de233cb5491c11b39c7c261fbfb9d48e92.tar.gz spack-ef9c80de233cb5491c11b39c7c261fbfb9d48e92.tar.bz2 spack-ef9c80de233cb5491c11b39c7c261fbfb9d48e92.tar.xz spack-ef9c80de233cb5491c11b39c7c261fbfb9d48e92.zip | |
qt: Silence build and force `xmlpatterns` library on for Qt4 (#19591)
For some mysterious reason Qt4 stopped building the xmlpatterns
component, needed by some downstream packages. With this patch, the
component successfully builds with
```
qt@4.8.7~dbus~debug~examples~framework~gtk~opengl~phonon+shared~sql~ssl~tools~webkit freetype=none arch=linux-rhel7-haswell %gcc@10.2.0
```
Diffstat (limited to 'var')
| -rw-r--r-- | var/spack/repos/builtin/packages/qt/package.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/var/spack/repos/builtin/packages/qt/package.py b/var/spack/repos/builtin/packages/qt/package.py index cbdff7c2cc..de058431da 100644 --- a/var/spack/repos/builtin/packages/qt/package.py +++ b/var/spack/repos/builtin/packages/qt/package.py @@ -333,10 +333,13 @@ class Qt(Package): conf('g++-unix')) if self.spec.satisfies('@4'): - # Necessary to build with GCC 6 and other modern compilers - # http://stackoverflow.com/questions/10354371/ + # The gnu98 flag is necessary to build with GCC 6 and other modern + # compilers (see http://stackoverflow.com/questions/10354371/); + # be permissive because of the abundance of older code, and hide + # all warnings because there are so many of them with newer + # compilers with open(conf('gcc-base'), 'a') as f: - f.write("QMAKE_CXXFLAGS += -std=gnu++98\n") + f.write("QMAKE_CXXFLAGS += -std=gnu++98 -fpermissive -w\n") @when('@4: %intel') def patch(self): @@ -523,6 +526,7 @@ class Qt(Package): '-{0}webkit'.format('' if '+webkit' in spec else 'no-'), '-{0}phonon'.format('' if '+phonon' in spec else 'no-'), '-arch', str(spec.target.family), + '-xmlpatterns', ]) # Disable phonon backend until gstreamer is setup as dependency |