summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Van Essen <vanessen1@llnl.gov>2022-12-15 14:29:36 -0800
committerGitHub <noreply@github.com>2022-12-15 23:29:36 +0100
commit3477d578a3a7d456a790e72755cbac456da99cb1 (patch)
tree6846631db730ace742fc8137dc29e535bb3da20b
parentaa8e1ba606c2f7814967a07cc64672166cff15c7 (diff)
downloadspack-3477d578a3a7d456a790e72755cbac456da99cb1.tar.gz
spack-3477d578a3a7d456a790e72755cbac456da99cb1.tar.bz2
spack-3477d578a3a7d456a790e72755cbac456da99cb1.tar.xz
spack-3477d578a3a7d456a790e72755cbac456da99cb1.zip
roctracer: fixed a bug in how the external is identified (#33517)
Make the package a proper ROCm package.
-rw-r--r--var/spack/repos/builtin/packages/roctracer-dev/package.py8
1 files changed, 2 insertions, 6 deletions
diff --git a/var/spack/repos/builtin/packages/roctracer-dev/package.py b/var/spack/repos/builtin/packages/roctracer-dev/package.py
index c971638c45..3d0764976d 100644
--- a/var/spack/repos/builtin/packages/roctracer-dev/package.py
+++ b/var/spack/repos/builtin/packages/roctracer-dev/package.py
@@ -8,7 +8,7 @@ import re
from spack.package import *
-class RoctracerDev(CMakePackage):
+class RoctracerDev(CMakePackage, ROCmPackage):
"""ROC-tracer library: Runtimes Generic Callback/Activity APIs.
The goal of the implementation is to provide a generic independent from
specific runtime profiler to trace API and asyncronous activity."""
@@ -81,7 +81,7 @@ class RoctracerDev(CMakePackage):
@classmethod
def determine_version(cls, lib):
- match = re.search(r"lib\S*\.so\.\d+\.\d+\.(\d)(\d\d)(\d\d)", lib)
+ match = re.search(r"rocm-(\d+)\.(\d+)\.(\d)/lib/lib\S*\.so\.\d+\.\d+\.\d+", lib)
if match:
ver = "{0}.{1}.{2}".format(
int(match.group(1)), int(match.group(2)), int(match.group(3))
@@ -90,10 +90,6 @@ class RoctracerDev(CMakePackage):
ver = None
return ver
- def setup_build_environment(self, build_env):
- spec = self.spec
- build_env.set("HIP_PATH", spec["hip"].prefix),
-
def patch(self):
filter_file(
"${CMAKE_PREFIX_PATH}/hsa",